Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] core: group reduction using union find #187

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] core: group reduction using union find #187

wants to merge 5 commits into from

Conversation

yliang412
Copy link
Member

@yliang412 yliang412 commented Oct 14, 2024 •
edited
Loading

The PR uses union-find to maintain group equivalence. This is done by maintaining

  • a DisjointSet of group ids
  • representative group id to Group mapping.

The "path compression" done during union operation speeds up tpch sqlplannertest run from ~89s to ~9s on local machine.

TODO

  • Better to have a Map<GroupId, Group> interface without thinking about reduced group. We can use DisjointGroup to replace get_reduced_group_id, Memo::groups::..., and Memo::merge_group functionalities.

@yliang412
core: use union-find to merge groups
bc17ae9 
Also improve tpch sqlplannertest run from ~89s to ~9s.

Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
remove ReducedGroupId
3b83135 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
remove sync on set itself
fd1f49e 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
implement DisjointGroupMap
4129dff 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
add DisjointGroup::merge
0890c3a 
Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yliang412